Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix capi-kubeadmconfig rule for hybrid providers #1494

Merged
merged 2 commits into from
Feb 10, 2025
+14 −1
Merged

fix capi-kubeadmconfig rule for hybrid providers #1494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e388078
fix capi-kubeadmconfig rule for hybrid providers
hervenicol Feb 7, 2025
ba116cf
fix KubeadmConfigNotReady query
hervenicol Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- fix capi-kubeadmconfig rule for hybrid providers

## [4.38.1] - 2025-02-06

### Fixed
Expand Down
11 changes: 10 additions & 1 deletion helm/prometheus-rules/templates/kaas/tenet/alerting-rules/capi-kubeadmconfig.rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,16 @@ spec:
- name: capi-kubeadmconfig
rules:
- alert: KubeadmConfigNotReady
expr: capi_kubeadmconfig_status_condition{type="Ready", status="False"} > 0
expr: |-
(
app_operator_app_info{status="not-installed", catalog=~"giantswarm|cluster|default", team!~"^$|noteam"}
Copy link
Contributor

@QuentinBisson QuentinBisson Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does that have to do with the app operator? I think the original metrics should bé capi_kubeadmconfig_status_condition{type="Ready right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp, what did I do!?? I screwed the query with a broken copy/paste, and there were no unit tests to catch it! 😱
Thanks for catching it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wonder how I did it, because my Grafana Explore panel was actually using the right query 🤔
image

Anyway, hopefully I've now pushed the proper one 🤞

* on(cluster_id) group_left(provider)
sum(
label_replace(
capi_cluster_info, "provider", "vsphere", "infrastructure_reference_kind", "VSphereCluster"
)
) by (cluster_id, provider)
) > 0
for: 1h
labels:
area: kaas
Expand Down