Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to NumberParseException #672

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

BenMorel
Copy link
Contributor

No description provided.

@BenMorel
Copy link
Contributor Author

@giggsey Would you be open to another PR adding strong types to properties, parameters, return types throughout the codebase? The codebase can be modernized quite a lot, while keeping compatibility with PHP 7.4.

@giggsey giggsey merged commit 0ecf954 into giggsey:master Feb 24, 2025
6 of 7 checks passed
@giggsey
Copy link
Owner

giggsey commented Feb 24, 2025

Thanks.

I think adding stronger types will be fine for @internal classes, or private properties. Anything else would be a BC break, which I'm not keen on.

libphonenumber-for-php-lite has the stronger types from the more modern PHP.

@BenMorel
Copy link
Contributor Author

I understand, matching Google's releases implies not being able to break things whenever you want. If Google ever releases a v9, maybe it'll be an opportunity to perform this upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants