Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function to match a native TIA portal export to a DB layout specification string #533

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

function to match a native TIA portal export to a DB layout specification string #533

Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
01056f0
first try
Novecento99 Sep 10, 2024
77d3ad8
first try
Novecento99 Sep 10, 2024
dce354f
str as return
Novecento99 Sep 10, 2024
976e6fa
newline at the end of file
Novecento99 Sep 10, 2024
7bee9e9
spazi
Novecento99 Sep 10, 2024
8db4c35
altri spazi
Novecento99 Sep 10, 2024
82e8b4f
ok
Novecento99 Sep 10, 2024
c08e5ca
daje
Novecento99 Sep 10, 2024
df74126
lol
Novecento99 Sep 10, 2024
c4681c7
_instead of maiusc
Novecento99 Sep 10, 2024
fd1f948
ottimo
Novecento99 Sep 10, 2024
3a318ea
spazi
Novecento99 Sep 10, 2024
1392977
no ex
Novecento99 Sep 10, 2024
e97bc34
replaced the list with a set
Novecento99 Sep 23, 2024
e629448
removed usless check
Novecento99 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions snap7/util/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,50 @@
logger = getLogger(__name__)


def prepare_tia_export_to_parse(txt_path: str) -> str:
"""Return a string that can be ingested by parse_specification
from a .txt file directly copied and pasted from TIA Portal.
It also handles duplicate variable names by progressively appending “_X”.

Args:
tia_export: path to the .txt

Returns:
string ready to be parsed
"""

with open(txt_path, "r") as file:
db_specification = ""

valid_list = ["BOOL", "DWORD", "INT", "DINT", "CHAR", "STRING", "DATE_AND_TIME", "TIME_OF_DAY", "REAL", "BYTE"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If you replace the list with a set, the operation x in s will be faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

var_names: list[str] = []

for line in file:
line = line.lstrip("\t")
parsed_line = line.split("\t")

var_name = parsed_line[0]
var_type = parsed_line[1].upper()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the literals in valid_names are uppercase? If they were lowercase, you wouldn't need to call .upper() for every line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid_names are list a copied from another part of this repo.
TIA portal exports variabiles types with the first letter in uppercase anyway

var_offset = parsed_line[2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the export file format looks like. Can there be empty lines or comments in it? This could cause an exception, something like 'list index out of range'

Copy link
Contributor Author

@Novecento99 Novecento99 Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I know: no.
this is an example of tia export:

PRESENT Bool 3968.0 false --- False True True True False PIECE PRESENT SCRAP Bool 3968.1 false --- False True True True False PIECE SCRAP READY Bool 3968.2 false --- False True True True False PIECE READY DRY_TEST Bool 3968.3 false --- False True True True False DRY TEST MOVING Bool 3968.4 false --- False True True True False PIECE MOVING SCANNED Bool 3968.5 false --- False True True True False QR_NOK Bool 3968.6 false --- False True True True False QR CODE NOT OK LONG_PROFILE Bool 3968.7 false --- False True True True False VB_ACK Bool 3969.0 false --- False True True True False


to_add = "_0"
for name in reversed(var_names):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a dictionary, where the key is var_name and the value is a counter, would be cleaner and more efficient than using a list. Something like this:

var_names: dict[str, int] = {}
to_add = var_names.setdefault(var_name, 0)
var_names[var_name] += 1
var_name = f'{var_name}_{to_add}'

And you won’t need an inner loop in this case.

name = str(name)
if name.rsplit("_")[0] == var_name:
print(name.rsplit("_")[-1])
to_add = "_" + str(int(name.rsplit("_")[-1]) + 1)
break

var_name = var_name + to_add
var_names.append(var_name)

if var_type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If var_type is an empty string, then var_type in valid_list is will be False. So there is no point to check var_type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thankyou

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

if var_type in valid_list:
new_line = var_offset + "\t" + var_name + "\t" + var_type
db_specification = db_specification + "\n" + new_line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Perhaps appending "new_line" to a list and then using join() is more efficient. But I’m not sure it makes a significant difference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt so, especially considering this function is meant to be run only one time for db....

return db_specification


def parse_specification(db_specification: str) -> Dict[str, Any]:
"""Create a db specification derived from a
dataview of a db in which the byte layout
Expand Down
Loading