Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear title when no tabs are open #843

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: clear title when no tabs are open #843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7b917
fix: clear title when no tabs are open
mguellsegarra Jan 24, 2025
5b62366
Merge branch 'v2' into fix/clear-title-when-no-tabs
mguellsegarra Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/context/TabManagerContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ActionInfo, Tab, View, ViewType } from "@/types";
import { ShortcutApi } from "@/ui/FavouriteButton";
import React, { useState, useContext, useMemo } from "react";
import React, { useState, useContext, useMemo, useEffect } from "react";
import { useConfigContext } from "./ConfigContext";

export type TabManagerContextType = {
openAction: (action: ActionInfo) => void;
Expand Down Expand Up @@ -69,6 +70,17 @@ const TabManagerProvider = (props: TabManagerProviderProps): any => {
const currentTab = useMemo(() => {
return tabs.find((t) => t.key === activeKey);
}, [tabs, activeKey]);
const { title } = useConfigContext();

const noTabs = useMemo(() => {
return !(tabs?.length > 0);
}, [tabs]);

useEffect(() => {
if (noTabs) {
document.title = title;
}
}, [noTabs, title]);

return (
<TabManagerContext.Provider
Expand Down
Loading