Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #17

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update CODEOWNERS #17

merged 1 commit into from
Oct 17, 2024

Conversation

shige
Copy link
Member

@shige shige commented Oct 17, 2024

Summary

Update CODEOWNERS.

Changes

Update CODEOWNERS for current operations.

@shige shige self-assigned this Oct 17, 2024
@shige shige requested review from a team, satococoa, toyamarinyon and koji-m and removed request for a team October 17, 2024 03:39
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:41am

Copy link
Contributor

@koji-m koji-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@satococoa satococoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the objective of this pull request.

The giselle-dev team does not exist in route06inc/giselle. Could you specify the users to be set as code owners?

@shige
Copy link
Member Author

shige commented Oct 17, 2024

@toyamarinyon

Please confirm the objective of this pull request.

"Update CODEOWNERS for current operations."
I simply changed the CODEOWNERS setting to the same as the one in the repository before migrating to this repository.

The giselle-dev team does not exist in route06inc/giselle. Could you specify the users to be set as code owners?

Can you take a look at this team https://github.com/orgs/route06inc/teams/giselle-dev ?

@shige shige requested a review from toyamarinyon October 17, 2024 04:56
Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply changed the CODEOWNERS setting to the same as the one in the repository before migrating to this repository.

Understood. I recognize the objective of this change.

Can you take a look at this team https://github.com/orgs/route06inc/teams/giselle-dev ?

I apologize for the initial confusion. Upon further investigation, I was able to locate the team. It's found at route06inc/giselle/giselle-dev.

Initially, I only checked within the route06inc organization directly, which is why I didn't find it at first. The team is actually nested under the giselle project within the route06inc organization.

@shige
Copy link
Member Author

shige commented Oct 17, 2024

Thank you for your kind review!

@shige shige merged commit 729296b into main Oct 17, 2024
4 checks passed
@shige shige deleted the update-codeowners branch October 17, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants