Minor fixups from #44 (for tech docs & VSCode settings) #45
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the reference to 'creationToken' in the 'git fetch' flow by changing it to 'minCreationToken', consistent with the other diagrams in the document. Signed-off-by: Victoria Dye <vdye@github.com>
Move the 'editor.wordWrap = false' and 'files.trimTrailingWhitespace = true' settings into a general scope from their previous language-specific configuration. These represent the default values we want for any language. These settings can still be toggled on a language-by-language basis if necessary in the future. Signed-off-by: Victoria Dye <vdye@github.com>
ldennington
reviewed
Apr 26, 2023
.vscode/settings.json
Outdated
| "*.sh": "shellscript", | ||
| "prerm": "shellscript", | ||
| "postinstall": "shellscript", | ||
| "*.js": "typescript", |
There was a problem hiding this comment.
Nit: should this be "javascript"?
There was a problem hiding this comment.
Ah sorry about that 🤦♀️ Fixed in latest push!
Add indentation settings for TypeScript and Javascript (currently used in the integration/end-to-end tests). These settings are consistent with the conventions already used in those files; this patch just codifies them. Signed-off-by: Victoria Dye <vdye@github.com>
vdye
force-pushed
the
vdye/followups-to-tech-docs
branch
from
ddc9c57 to
3f2c022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 changes
creationTokentominCreationTokenin thegit fetchflowchart (only caught that after merging #44).Commit 2 de-duplicates some of the common language settings in
.vscode/settings.json, and commit 3 adds indentation settings in that file fortypescriptandjavascript(as recommended by @ldennington in #44 (comment))