Daemon-related bug fixes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update web server daemon config to reflect the application's new bundle id: com.git-ecosystem.gitbundleserver. Signed-off-by: Lessley Dennington <[email protected]>
Remove the currently-commented "After" step for daemon tests. If uncommented, this step would stop a running daemon, which could cause issues for users who had started their daemons before an integration test run and would expect them to still be running after the test run completes. Signed-off-by: Lessley Dennington <[email protected]>
vdye
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes oversights from #49 and #39.
The first commit updates the web server daemon with the application's new bundle id:
com.git-ecosystem.gitbundleserver. The second commit removes an unnecessary commented step in the daemon-specific integration tests.