-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generic): check local token expiry #1837
base: main
Are you sure you want to change the base?
Conversation
I'd very much like to have any approach towards identifying local token expiration.
The last approach changing the API for the storage format (#1464) is now stale for almost a year. The |
b467d37
to
482a1ea
Compare
Some major caveat found while trying to prototype a "username@expiration" approach: Some storage back ends may also be thrown off by the changing username… Relative time in protocol additionally indicates this is to be used as a transient element. For now I'd definitely favor using structured token detection (transparent, backward-compatible, non-intrusive). |
482a1ea
to
c8a7e32
Compare
c8a7e32
to
e7d3dc2
Compare
add minimal JWT data class for content decoding and extraction add decode support to Base64Url converter override GenericHostProvider credential query to check for JWT content add expiry check for JWT refresh token
e7d3dc2
to
d7e4f76
Compare
Not checking for expired tokens triggers failures on first fetch/push after expiration.
Many Oauth2 implementations use JWT, where expiration time stamp is stored in structured data.
fixes: #1408, #1784