Skip to content

CI: make and call reusable workflow for running tests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

jeremyd2019
Copy link
Contributor

If this works, we could call this workflow from
git-for-windows/msys2-runtime too instead of duplicating it.

@jeremyd2019 jeremyd2019 force-pushed the test-callable-workflow branch from c19fe49 to 686936b Compare March 21, 2025 18:44
After this, we could call this workflow from
git-for-windows/msys2-runtime too instead of duplicating it.

Signed-off-by: Jeremy Drake <[email protected]>
@jeremyd2019 jeremyd2019 force-pushed the test-callable-workflow branch from 686936b to 75b8480 Compare March 21, 2025 19:05
@jeremyd2019
Copy link
Contributor Author

@jeremyd2019 jeremyd2019 marked this pull request as ready for review March 21, 2025 19:07
@jeremyd2019
Copy link
Contributor Author

I kind of expected this same sort of test matrix thing in git-for-windows/git, but it seems there's a somewhat similar but different matrix going on there. I wonder if they could be unified, and this callable workflow put into git-for-windows/git instead.

@jeremyd2019 jeremyd2019 changed the title CI: call reusable workflow for running tests CI: make and call reusable workflow for running tests Mar 21, 2025
@dscho
Copy link
Member

dscho commented Mar 25, 2025

I kind of expected this same sort of test matrix thing in git-for-windows/git, but it seems there's a somewhat similar but different matrix going on there. I wonder if they could be unified, and this callable workflow put into git-for-windows/git instead.

The reason why git-for-windows/git does not have that matrix is that its main CI is derived from git/git's.

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dscho dscho merged commit d665063 into main Mar 25, 2025
22 checks passed
@dscho dscho deleted the test-callable-workflow branch March 25, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants