Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git for Windows via winget #1655

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Git for Windows via winget #1655

merged 1 commit into from
Dec 20, 2021

Conversation

adsingh14
Copy link
Contributor

Changes

Resolved #1652 by adding 'winget-cli' command on Windows downloads page.

@pedrorijo91 pedrorijo91 temporarily deployed to git-scm-pr-1655 December 14, 2021 11:09 Inactive
@pedrorijo91
Copy link
Member

version deployed at https://git-scm-pr-1655.herokuapp.com

@peff
Copy link
Member

peff commented Dec 14, 2021

It's a little funny that we auto-start the download and have instructions for other ways of getting it. But that's not entirely new (i.e., we already have links to the other setup options, as well as the portable installers). We've talked about dropping the auto-download and making this more like the linux and mac pages that just list the various options. But if we do that it can be done in a separate PR.

@peff peff temporarily deployed to git-scm-pr-1655 December 14, 2021 19:48 Inactive
@adsingh14
Copy link
Contributor Author

It's a little funny that we auto-start the download and have instructions for other ways of getting it. But that's not entirely new (i.e., we already have links to the other setup options, as well as the portable installers). We've talked about dropping the auto-download and making this more like the linux and mac pages that just list the various options. But if we do that it can be done in a separate PR.

I would like to work on this but unsure which file is connected with 'auto-download' option?

@peff
Copy link
Member

peff commented Dec 15, 2021

I would like to work on this but unsure which file is connected with 'auto-download' option?

I think it's triggered by the presence of the auto-download-link id in

<%= raw "<strong><a id=\"auto-download-link\" href=\"#{@download.url}\">Click here to download manually</a><span class=\"hide\">, if your download hasn't started.</span></strong>" %>

That's power by some javascript here:

var src = $('#auto-download-link').attr('href');

that could probably go away once we're not using it anymore.

@adsingh14

This comment has been minimized.

@adsingh14

This comment has been minimized.

@pedrorijo91 pedrorijo91 temporarily deployed to git-scm-pr-1655 December 20, 2021 10:24 Inactive
@pedrorijo91 pedrorijo91 merged commit 02815ce into git:main Dec 20, 2021
@adsingh14 adsingh14 deleted the winget-cli branch December 20, 2021 11:46
@adsingh14
Copy link
Contributor Author

@pedrorijo91 I'm just confirming that the download pages aren't working on local ?

@peff
Copy link
Member

peff commented Dec 20, 2021

The download pages should work OK locally. Make sure you've run both rake local_index (or preindex if you prefer) to pick up the latest source version, and rake downloads to pick up the binary download links for Windows and macOS.

@adsingh14
Copy link
Contributor Author

The download pages should work OK locally. Make sure you've run both rake local_index (or preindex if you prefer) to pick up the latest source version, and rake downloads to pick up the binary download links for Windows and macOS.

After running those commands I'm unable to render 'downloads sub-pages' which includes Windows/Mac/Linux OS.

@rimrul
Copy link
Contributor

rimrul commented Dec 30, 2021

The client requires Windows 10 1809 (build 17763) or later at this time. Windows Server 2019 is not supported as the Microsoft Store is not available nor are updated dependencies. It may be possible to install on Windows Server 2022, this should be considered experimental (not supported), and requires dependencies to be manually installed as well.

The text should probably mention that winget only works on Windows 10 and Windows 11 (and not even Windows Server). Git for Windows still supports Windows Vista and newer.

And winget isn't the only "package manager" for Windows that re-packages the Git for Windows releases. There's also scoop and chocolatey

@adsingh14
Copy link
Contributor Author

The text should probably mention that winget only works on Windows 10 and Windows 11 (and not even Windows Server). Git for Windows still supports Windows Vista and newer.

There's a link in winget section which covers the prerequisites and compatibility doubts.

And winget isn't the only "package manager" for Windows that re-packages the Git for Windows releases. There's also scoop and chocolatey

You're welcome to make changes.

@dscho
Copy link
Member

dscho commented Aug 12, 2024

I just found out that the Git home page recommends using winget, via git-for-windows/git-for-windows.github.io#50.

It's quite surprising because winget is definitely not a paved path, nor even officially supported by the Git for Windows project.

So maybe this was a bit of a misleading change, in particular given the refusal to describe other "package managers" (that are equally unsupported by the Git for Windows project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add mentioning of winget installation method on https://git-scm.com/downloads
5 participants