Skip to content

[work in progress] updating to django 3.1+ #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[work in progress] updating to django 3.1+ #84

wants to merge 12 commits into from

Conversation

sethwoodworth
Copy link
Contributor

@sethwoodworth sethwoodworth commented Dec 17, 2020 •
edited
Loading

TODO:

  • package django-zurb-foundation doesn't work with the latest versions of django
  • unable to set STATIC_URL base to /static/ in local development, possibly due to a very old settings.py configuration
  • ensure settings.prod and settings.dev split works in prod

@sethwoodworth sethwoodworth added the dependencies Pull requests that update a dependency file label Dec 17, 2020
@eshellman
Copy link
Contributor

thanks for working on this. Unglue.it is still at 1.11 and I spent a few days working on moving to 2.x but haven't had time to go finish up.

@sethwoodworth
Copy link
Contributor Author

This seems like a not-very-glamorous but needed task to future proof our websites. I'll take this as far as I can in local development, but I'll need to get my aws access set up again to ensure we can re-deploy the site.
If I can get the django updates for gitensite figured out, I can do the same for unglueit 👍

eshellman
eshellman reviewed Dec 21, 2020
View reviewed changes
README.asciidoc Outdated
@@ -23,6 +24,10 @@ From the root of the project
For every new terminal, or when returning to work on the project, you will need to run

source venv/bin/activate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the documentation is out of date

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the env setup instructions use requirements.txt, which you've deleted

Pipfile Outdated

[packages]
django = "==1.11.28"
django = ">=3.1.4"
gitberg = "==0.7.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want >0.7.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's now at 0.7.4

Pipfile
@@ -24,4 +26,4 @@ boto3 = "*"
appdirs = "==1.4.3"

[requires]
python_version = "3.6"
python_version = "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ebcli uses some config magic that's not clear to me, but the install platform default is py3.7 - look in .elasticbeanstalk/config.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything 3.6+ will let me use f-strings, so that should work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the elastic beanstalk config, the base image we're using is python3.6
image

So I'll revert this back to 3.6 and make sure the site works with 3.6-3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshellman eshellman eshellman left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethwoodworth @eshellman