Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: wire up contrib/credential #1859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hickford
Copy link

@hickford hickford commented Jan 31, 2025

It would be neat to also run test t0303-credential-external with GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.

CC: Patrick Steinhardt <[email protected]

@hickford hickford changed the title meson: credential meson: wire up contrib/credential Jan 31, 2025
Fix an error when compiling with MSVC.

Signed-off-by: M Hickford <[email protected]>
@hickford
Copy link
Author

/submit

Copy link

gitgitgadget bot commented Feb 13, 2025

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1859/hickford/meson-credential-v1

To fetch this version to local tag pr-1859/hickford/meson-credential-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1859/hickford/meson-credential-v1

Copy link

gitgitgadget bot commented Feb 13, 2025

This patch series was integrated into seen via git@16c9bca.

@gitgitgadget gitgitgadget bot added the seen label Feb 13, 2025
Copy link

gitgitgadget bot commented Feb 14, 2025

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

On Thu, Feb 13, 2025 at 06:37:37PM +0000, M Hickford via GitGitGadget wrote:
> It would be neat to also run test t0303-credential-external with
> GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.

Thanks for working on this! I have a patch series sitting locally for a
while that wires up all credential helpers and more, as well. It also
wires up netrc and fixes its tests to allow out-of-tree testing, which
doesn't work right now. What I don't have though is the patch for the
wincred helper.

The patch series is currently still blocked on [1], which is why I have
been holding back on it. Would you mind if I picked your patch to fix
wincred, but we then wait with wiring up remaining credential helpers
until my follow-up patch series is unblocked?

Meanwhile, I'd appreciate any feedback on [1] to help move it forward,
if you have the time :)

Patrick

[1]: <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant