Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate information from the wiki to GitGitGadget's home page #21

Merged
merged 16 commits into from
Mar 5, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented Mar 3, 2025

The idea of having a wiki sounded better when I added information there than years later, when I needed to limit write permissions to combat spam. That kind of defeats the purpose of a wiki, where it should be as easy as possible to edit the information for anyone who sees a mistake (or something that would benefit from an improvement).

One example where this really irks is gitgitgadget/gitgitgadget#1843: A good suggestion how to improve the documentation how to reply to comments on the Git mailing list, and the person who proposed a change could not make that change themselves.

So let's import the information from the wiki pages and put them on GitGitGadget's site instead. The next step after merging this PR will be to edit the wiki pages themselves to redirect to https://gitgitgadget.github.io/architecture and https://gitgitgadget.github.io/reply-to-this instead.

dscho and others added 14 commits January 25, 2019 13:34
Signed-off-by: Johannes Schindelin <[email protected]>
This merges the pages from the wiki, they will be subsequently
transformed into `.html` pages.

The reason for the migration away from the wiki is that the wiki can
only be edited by people with `push` permissions, to combat spam. But
GitGitGadget's home page can be edited via PRs.

Signed-off-by: Johannes Schindelin <[email protected]>
This is not needed on GitGitGadget's home page, which already has an
`index.html`.

Signed-off-by: Johannes Schindelin <[email protected]>
These filenames will be used in the URLs. Therefore, long names and
special characters are undesirable.

Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Let's use 2-space indents everywhere in this repository.

This commit is best viewed with `git show -w`.

Signed-off-by: Johannes Schindelin <[email protected]>
This imitates the Grunt-based setup of git-for-windows.github.io.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Mar 3, 2025
@dscho dscho force-pushed the add-information-from-the-wiki branch from 77429d3 to dda7067 Compare March 3, 2025 08:31
This will make it more convenient to update the site: Simply modifying
the `.md` files will be enough, and the PR build will do the rest.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the add-information-from-the-wiki branch from dda7067 to e395bbf Compare March 3, 2025 09:21
@dscho dscho changed the title Add information from the wiki Migrate information from the wiki to GitGitGadget's home page Mar 3, 2025
@dscho dscho merged commit 55522b9 into main Mar 5, 2025
@dscho dscho deleted the add-information-from-the-wiki branch March 5, 2025 13:02
@dscho
Copy link
Member Author

dscho commented Mar 5, 2025

A couple of (potential) follow-ups that come to my mind are:

  • Adjust GitGitGadget to link the the new reply-to-this location instead of the old one.
  • Add a navigation bar to the HTML pages so that the new pages are reachable.
  • Verify that the PR workflow succeeds to push updates even for PRs that originated from a fork.
  • To provide some "before/after" screenshots (which GitHub sadly does not support for anything other than images or "prose documents"), the PR workflow could be extended to use Playwright to take screenshots and paste them into a "before/after" table in a PR comment.
  • To offer access to GitHub's slider view to compare images, the PR workflow could even push a throw-away ref with a commit that adds a screenshot of the page prior to the PR (if the page existed) and then commits a screenshot of the post-PR state, then add a PR comment linking to that commit (which has that slider view).

dscho added a commit that referenced this pull request Mar 8, 2025
Rather than trying to continue running something home-grown, let's
switch to a proper static site generator.

This partially addresses some concerns I [raised after integrating the
wiki
pages](#21 (comment))
and the problems we ran into when [the workflow to update the HTML pages
failed in a PR by a
contributor](#22 (comment)):
While it still does not offer convenient before/after views, it at least
allows to preview the changes in a fork, just like this here PR can be
previewed at https://dscho.github.io/gitgitgadget.github.io/

So why even bother with a powerful site generator like Hugo for
something as small as GitGitGadget's home page? Well, here are a couple
of reasons:

- As you can see
https://dscho.github.io/gitgitgadget.github.io/architecture, it re-adds
the syntax highlighting in code blocks that were lost in the transition
away from the wiki.
- It will make auto-generating a navigation bar (or a central index
page) much easier.
- It will make it easier to maintain a unified look-and-feel, e.g. when
adding something like an "Edit on GitHub" button.
- It should make it somewhat easier to make the site
[responsive](#19)
because of a much more standard way to build the site.
- The migration of the wiki pages was meant as a blueprint I could
follow in Git for Windows, where I want to stop wasting my time battling
spam and vandalism, and any subsequent work over here that can help with
that can increase the synergy between both projects.
dscho added a commit to dscho/gitgitgadget that referenced this pull request Mar 14, 2025
Since the wiki was locked down for external contributors (to prevent
spam and vandalism), it was not really a good place for the information.
As of gitgitgadget/gitgitgadget.github.io#21 it
moved to GitGitGadget's home page.

Let's stop referring to the wiki for that reason, and refer to the new
location instead.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Mar 14, 2025

  • Adjust GitGitGadget to link the the new reply-to-this location instead of the old one.

gitgitgadget/gitgitgadget#1852

  • Add a navigation bar to the HTML pages so that the new pages are reachable.

I guess another idea would be to make it a "site map" or "site index", similar to what I did over in git-for-windows/git-for-windows.github.io@10c86c2.

  • Verify that the PR workflow succeeds to push updates even for PRs that originated from a fork.

Since moving to Hugo in #23, that is no longer relevant.

  • To provide some "before/after" screenshots (which GitHub sadly does not support for anything other than images or "prose documents"), the PR workflow could be extended to use Playwright to take screenshots and paste them into a "before/after" table in a PR comment.

  • To offer access to GitHub's slider view to compare images, the PR workflow could even push a throw-away ref with a commit that adds a screenshot of the page prior to the PR (if the page existed) and then commits a screenshot of the post-PR state, then add a PR comment linking to that commit (which has that slider view).

These would still be "nices-to-have".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant