Skip to content

fix: remove unused example spot_instance_termination_watcher #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

piscue
Copy link
Contributor

@piscue piscue commented Oct 31, 2024

I don't see this being used, and the only example available, it lead to confusion

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for taking the time to make a contribution. However this example is there for a reason. People can quickly see what is possible and enable it.

But I think we should find a better way how we do this for examples, because drawback is we can not verify the code in CI.

@piscue
Copy link
Contributor Author

piscue commented Nov 1, 2024

I did double check the adding it to our multi runner setup and the plan show us the error

An argument named "spot_instance_termination_watcher" is not expected here.

it could be that was renamed to the example after? we use instance_termination_watcher without problems

  # Enable spot termination watcher
  # spot_instance_termination_watcher = {
  #   enable = true
  # }

  # Enable to track the spot instance termination warning
  # instance_termination_watcher = {
  #   enable         = true
  # }

@npalm npalm merged commit ad865a7 into github-aws-runners:main Nov 5, 2024
42 checks passed
npalm pushed a commit that referenced this pull request Nov 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.18.3](philips-labs/terraform-aws-github-runner@v5.18.2...v5.18.3)
(2024-11-05)


### Bug Fixes

* **lambda:** bump the aws group in /lambdas with 6 updates
([#4235](https://github.com/philips-labs/terraform-aws-github-runner/issues/4235))
([ef89b98](philips-labs/terraform-aws-github-runner@ef89b98))
* remove unused example spot_instance_termination_watcher
([#4226](https://github.com/philips-labs/terraform-aws-github-runner/issues/4226))
([ad865a7](philips-labs/terraform-aws-github-runner@ad865a7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants