Recognize Apex .trigger files - #8183
Open
look wants to merge 2 commits into
Open
Conversation
Add targeted .trigger heuristics without changing Shell fallback or shebang precedence. Cover the existing collision samples, mixed-case multiline declarations, and ordinary shell content. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the Generic fixture convention for a file that should not match a heuristic, while retaining its full Shell detection assertion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
look
marked this pull request as ready for review
September 9, 2026 20:45
lildude
reviewed
Sep 10, 2026
Member
There was a problem hiding this comment.
Why have you put the samples where you have rather than using the sample directories that already exist for these languages? "Generic" is going to cause confusion as people will start putting samples for extensions listed in generic.yaml there when they should be in the respective language directories.
We also need explicit mentioning of the licence of the samples in the PR template for all new extensions.
I'm only comment on this PR but the same applies to the others which are doing similar things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recognize Apex
.triggerfiles from trigger declarations and sharing-qualified class declarations without resorting to the classifier. Matching is case-insensitive and supports multiline declarations; unmatched files continue through existing detection, and Shell shebang precedence is unchanged.Reuses all existing Apex/Shell
.triggersamples and adds two original Generic fixtures for multiline syntax and Shell negative coverage. No third-party samples are added. Public examples include Apex Recipes and NPSP, also discoverable through non-fork usage search.Checklist: