Skip to content

Rule 7.4: Improve performance #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Rule 7.4: Improve performance #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions c/misra/src/rules/RULE-7-4/StringLiteralAssignedToNonConstChar.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ class WideCharPointerType extends PointerType {
override string getAPrimaryQlClass() { result = "WideCharPointerType" }
}

class GenericCharPointerType extends PointerType {
class GenericCharPointerType extends Type {
GenericCharPointerType() {
/* This type resolves to wchar_t* (which is in turn a typedef depending on its implementation) */
this.resolveTypedefs*() instanceof WideCharPointerType
// A wide char pointer type
this instanceof WideCharPointerType
or
/* This type eventually resolves to char* */
this.resolveTypedefs*() instanceof CharPointerType
// A char pointer type
this.getUnspecifiedType() instanceof CharPointerType
or
// A typedef to any such type.
// Note: wchar_t is usually a typedef, so we cannot just use getUnspecifiedType() here.
this.(TypedefType).getBaseType() instanceof GenericCharPointerType
}
}

Expand Down