A3-9-1: exclude fps on post increment and decrement operators

change_notes/2024-06-18-fix-fp-614-A3-9-1.md

@@ -0,0 +1,2 @@
+- `A3-9-1` - `VariableWidthIntegerTypesUsed.ql`:
+  - Fixes #614. Excludes post increment and decrement operators.

cpp/autosar/src/rules/A3-9-1/VariableWidthIntegerTypesUsed.ql

@@ -20,6 +20,7 @@ import codingstandards.cpp.autosar
 import codingstandards.cpp.EncapsulatingFunctions
 import codingstandards.cpp.BuiltInNumericTypes
 import codingstandards.cpp.Type
+import codingstandards.cpp.Operator
 
 from Variable v, Type typeStrippedOfSpecifiers
 where
@@ -30,5 +31,8 @@ where
     typeStrippedOfSpecifiers instanceof UnsignedCharType or
     typeStrippedOfSpecifiers instanceof SignedCharType
   ) and
-  not v instanceof ExcludedVariable
+  not v instanceof ExcludedVariable and
+  //post-increment/post-decrement operators are required by the standard to have a dummy int parameter
+  not v.(Parameter).getFunction() instanceof PostIncrementOperator and
+  not v.(Parameter).getFunction() instanceof PostDecrementOperator
 select v, "Variable '" + v.getName() + "' has variable-width type."

cpp/autosar/test/rules/A3-9-1/test.cpp

@@ -70,4 +70,9 @@ void test_variable_width_type_qualified_variables() {
   volatile long l2;           // NON_COMPLIANT
   volatile unsigned long ul2; // NON_COMPLIANT
   volatile signed long sl2;   // NON_COMPLIANT
-}
+}
+
+struct test_fix_fp_614 {
+  test_fix_fp_614 operator++(int); // COMPLIANT
+  test_fix_fp_614 operator--(int); // COMPLIANT
+};

cpp/common/src/codingstandards/cpp/Operator.qll

@@ -215,6 +215,20 @@ class IncrementOperator extends Operator {
   }
 }
 
+class PostIncrementOperator extends Operator {
+  PostIncrementOperator() {
+    hasName("operator++") and
+    getNumberOfParameters() = 1
+  }
+}
+
+class PostDecrementOperator extends Operator {
+  PostDecrementOperator() {
+    hasName("operator--") and
+    getNumberOfParameters() = 1
+  }
+}
+
 class StructureDerefOperator extends Operator {
   StructureDerefOperator() {
     hasName("operator->") and