-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Concurrency9 package #819
Implement Concurrency9 package #819
Conversation
3e3ea7d
to
713c675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 35 out of 55 changed files in this pull request and generated no comments.
Files not reviewed (20)
- c/common/src/codingstandards/c/SubObjects.qll: Language not supported
- c/common/src/codingstandards/c/initialization/GlobalInitializationAnalysis.qll: Language not supported
- c/common/test/includes/standard-library/stdlib.h: Language not supported
- c/misra/src/rules/DIR-5-1/PossibleDataRaceBetweenThreads.ql: Language not supported
- c/misra/src/rules/RULE-22-14/MutexNotInitializedBeforeUse.ql: Language not supported
- c/misra/src/rules/RULE-22-15/ThreadResourceDisposedBeforeThreadsJoined.ql: Language not supported
- c/misra/src/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.ql: Language not supported
- c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLocked.ql: Language not supported
- c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLockedAudit.ql: Language not supported
- c/misra/src/rules/RULE-22-19/ConditionVariableUsedWithMultipleMutexes.ql: Language not supported
- c/misra/src/rules/RULE-22-20/ThreadStorageNotInitializedBeforeUse.ql: Language not supported
- c/misra/src/rules/RULE-22-20/ThreadStoragePointerInitializedInsideThread.ql: Language not supported
- c/misra/test/rules/DIR-5-1/PossibleDataRaceBetweenThreads.expected: Language not supported
- c/misra/test/rules/DIR-5-1/PossibleDataRaceBetweenThreads.qlref: Language not supported
- c/misra/test/rules/DIR-5-1/test.c: Language not supported
- c/misra/test/rules/RULE-22-15/ThreadResourceDisposedBeforeThreadsJoined.expected: Language not supported
- c/misra/test/rules/RULE-22-15/ThreadResourceDisposedBeforeThreadsJoined.qlref: Language not supported
- c/misra/test/rules/RULE-22-15/test.c: Language not supported
- c/misra/test/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.expected: Language not supported
- c/misra/test/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.qlref: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Apologies @nicolaswill, didn't realize this was red. Fixed CI/CD! |
c/common/src/codingstandards/c/initialization/GlobalInitializationAnalysis.qll
Show resolved
Hide resolved
c/misra/src/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.ql
Outdated
Show resolved
Hide resolved
c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLockedAudit.ql
Outdated
Show resolved
Hide resolved
c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLockedAudit.ql
Outdated
Show resolved
Hide resolved
c/misra/src/rules/RULE-22-19/ConditionVariableUsedWithMultipleMutexes.ql
Outdated
Show resolved
Hide resolved
This is really great work... I love how the libraries are rather modular and reusable. I've made some comments that are for the most part minor. I've verified the functionality based on your test-cases and thought of some small edge-cases... while I'm sure there are more (mainly in terms of false negatives), the rest LGTM. Happy to merge once the smaller fixes are addressed. |
c/misra/src/rules/RULE-22-20/ThreadStorageNotInitializedBeforeUse.ql
Outdated
Show resolved
Hide resolved
cpp/common/src/codingstandards/cpp/concurrency/LockingOperation.qll
Outdated
Show resolved
Hide resolved
Thank you Nick! This is ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed a small typo in my previous review. Otherwise, LGTM!
…lement-concurrency9-package
Description
Implement Concurrency9 package on top of Concurrency8.
Break apart
Concurrency.qll
.Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
DIR-5-1
RULE-22-14
RULE-22-15
RULE-22-17
RULE-22-18
RULE-22-19
RULE-22-20
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.