Rust: Model clone
#18676
Merged
Rust: Model clone
#18676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
rust-model-clone
branch
from
abda28d to
9073f56
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
force-pushed
the
rust-model-clone
branch
from
9073f56 to
86d7fea
Compare
hvitved
requested changes
Feb 6, 2025
| /** A model for `clone` on the `Clone` trait. */ | ||
|
|
||
| import rust | ||
| import codeql.rust.dataflow.FlowSummary |
hvitved
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clonemethod is very common in Rust and implementations should always make an exact clone of the input. So allowing value flow through anyclonemethod seems useful.I wasn't sure how to implement this. In C/C++ I think we have a way of adding flow that is based on data flow nodes, but here I extended
SummarizedCallable::Rangewhich is based on strings and thus feels a bit odd. Maybe we will want another way to add additional flow steps later, but for now this seems to work just fine.