Actions: avoid N^2 parsing in common cases #18686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser has an inherent N^2 blowup and will need a rewrite eventually. For now I'm just trying to make it not blow up as often.
There was a problem hiding this comment.
PR Overview
This pull request creates a new workflow file intended to test handling of large string data, including balanced and unbalanced quotes.
- Adds many_strings.yml with extensive echo statements for testing.
- Checks for potential N^2 behavior in the bash parser by using large datasets.
Changes
| File | Description |
|---|---|
| actions/ql/test/library-tests/.github/workflows/many_strings.yml | New workflow to exercise large string parsing logic |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bash parser has an inherent N^2 cost and we'll likely want to rewrite it eventually. But for now, this PR just makes it less likely to blow up in practice.