-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rust: Test and model some string and iterator methods #18701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6966c96
Rust: Add a test case for parse on a command line arg.
geoffw0 c597818
Rust: Add a flow test for to_string() and parse().
geoffw0 1ff7a52
Rust: Add a flow test for some iterator methods.
geoffw0 d0f5aad
Rust: Model to_string.
geoffw0 a8a0512
Rust: Model parse.
geoffw0 bce4735
Rust: Additional test case suggested by copilot.
geoffw0 78e3c89
Rust: Accept changes to integration tests.
geoffw0 f350181
Merge branch 'main' into nth
geoffw0 f5b9691
Rust: Accept fixed result.
geoffw0 e7fdfd0
Merge branch 'main' into nth
geoffw0 4f73429
Rust: Accept test changes after merging latest main.
geoffw0 f5ab6a6
Rust: Accept integration test changes.
geoffw0 edda26c
Merge branch 'main' into nth
geoffw0 e9b8ec9
Rust: Accept integration test changes (again).
geoffw0 c07a57b
Rust: Accept spurious test results (we need a barrier for numeric typ…
geoffw0 6c31473
Rust: Accept changes to the summary stats query .expected.
geoffw0 048f7db
Merge branch 'main' into nth
geoffw0 79525fa
Rust: Variant -> Field.
geoffw0 8024fb6
Rust: Add more models for Iterator.
geoffw0 12d5a30
Rust: Add a test of mutable iterators as well.
geoffw0 1a6c6a4
Rust: Effect on integration tests.
geoffw0 fdc76dd
Merge branch 'main' into nth
geoffw0 6cb8f65
Rust: Fix up .expected after merge.
geoffw0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
202 changes: 172 additions & 30 deletions
202
rust/ql/test/library-tests/dataflow/local/DataFlowStep.expected
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this call to
into_iter()
(from theIntoIter
trait), we don't seem to have a result forresolvable_resolved_paths
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hvitved would you mind taking a quick look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolvable_resolved_paths
is populated by the extractor, so I think @redsun82 or @aibaars can better explain this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue to track this (to separate this concern from merging the PR). I'm keen to hear what people think we need to do.