Skip to content

Fix typo in ReusableWorkflowsSinks.ql identifier #19277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felicitymay
Copy link
Contributor

Copilot spotted this when reviewing a PR in the CodeQL docs publication repository.

Will fixing this break anything else, or is safe to correct here?

@Copilot Copilot bot review requested due to automatic review settings April 10, 2025 17:42
@felicitymay felicitymay requested a review from a team as a code owner April 10, 2025 17:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • actions/ql/src/Models/ReusableWorkflowsSinks.ql: Language not supported

@github-actions github-actions bot added the Actions Analysis of GitHub Actions label Apr 10, 2025
@felicitymay felicitymay added the no-change-note-required This PR does not need a change note label Apr 10, 2025
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This change is safe for default and security-extended suite users.
It would churn things for security-and-quality suite users because we have accidentally include these telemetry queries in that suite. I'll merge and we can add a quick follow up to remove it from that suite; then those alerts (that should never have been shown) will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants