Skip to content

Update references to "Git reference" #16968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Conversation

phil-blain
Copy link
Contributor

@phil-blain phil-blain commented Apr 9, 2022

Why:

Update the "Using Git" section of the page "Git and GitHub learning resources" to bring it up to date.

What's being changed:

  • 1/4: git-and-github-learning-resources: mark "Git reference" as GitHub's
  • 2/4: git-and-github-learning-resources: fix URL for Git reference
  • 3/4: git-and-github-learning-resources: remove "Try Git" reference
  • 4/4: .gitattributes: mark '*.md' as Markdown files
Notes from the commit messages...

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

The "Git reference" is created and maintained by GitHub, not by the Git
community, so use "our" to refer to it.
The URL 'gitref.org' for the "Git Reference" does not work since August
2017 [1]. Fix the URL to point to the right place, and use an HTTPS URL.

[1] git/git-reference#112
The interactive "Try Git" tutorial that used to be available at
'try.github.com' [1] is not available since 2018 [2]. Stop mentioning
it.

[1] https://github.blog/2012-07-04-try-git-in-your-browser/
[2] git/git-scm.com#1239
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/get-started/quickstart/git-and-github-learning-resources.md Modified Original

Denote Markdown files as such with the 'diff' Git attribute [1]. This
allows various Git commands (diff [2, 3], grep [4, 5], log [6], blame
[7]) to show in which part of the "code" the changes are located in the
hunk header.

The history of the "Using Git" section modified in the previous commit
specific entry can now be interrogated using

    git log -L:"Using Git":content/get-started/quickstart/git-and-github-learning-resources.md

[1] https://git-scm.com/docs/gitattributes#_defining_a_custom_hunk_header
[2] https://git-scm.com/docs/git-diff#_generating_patch_text_with_p
[3] https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--W
[4] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--p
[5] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--W
[6] https://git-scm.com/docs/git-log#Documentation/git-log.txt--Lltfuncnamegtltfilegt
[7] https://git-scm.com/docs/git-blame#Documentation/git-blame.txt--Lltfuncnamegt
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Apr 11, 2022
@ramyaparimi
Copy link
Contributor

@phil-blain
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@felicitymay felicitymay added the engineering Will involve Docs Engineering label Apr 22, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-blain - thank you for taking the time to track down the missing site and open this PR to fix the references. Your help is much appreciated 💖

It looks as if one of the other references is no longer maintained, so I'm going to remove that link too. When we've resolved the question of the .gitattributes file, this pull request will be ready to merge.

@@ -18,7 +18,7 @@ shortTitle: Learning resources
---
## Using Git

Familiarize yourself with Git by visiting the [official Git project site](https://git-scm.com) and reading the [ProGit book](http://git-scm.com/book). You can review the [Git command list](https://git-scm.com/docs) or [Git command lookup reference](http://gitref.org) while using the [Try Git](https://try.github.com) simulator.
Familiarize yourself with Git by visiting the [official Git project site](https://git-scm.com) and reading the [ProGit book](http://git-scm.com/book). You can also review the [Git command list](https://git-scm.com/docs) or our [Git command lookup reference](https://git.github.io/git-reference/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the outdated link a git simulator and for tracking down the Git command reference that's backed by https://github.com/git/git-reference. 💖

It looks as if the Git command reference is no longer actively maintained, so I suggest we remove this reference too.

Suggested change
Familiarize yourself with Git by visiting the [official Git project site](https://git-scm.com) and reading the [ProGit book](http://git-scm.com/book). You can also review the [Git command list](https://git-scm.com/docs) or our [Git command lookup reference](https://git.github.io/git-reference/).
Familiarize yourself with Git by visiting the [official Git project site](https://git-scm.com) and reading the [ProGit book](http://git-scm.com/book). You can also review the [Git command list](https://git-scm.com/docs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I agree it does not look actively maintained, but it did help me at first when I was learning Git. So it's you call :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to know you found this resource useful, even though it's not actively maintained. I guess the core functionality of Git doesn't change much.

@felicitymay felicitymay requested a review from a team April 25, 2022 07:46
Copy link
Member

@rsese rsese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on that .gitattributes update

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-blain - thanks for your patience with our review process ✨
@rsese - thank you for confirming that the change to .gitattributes is safe 🙇🏻‍♀️

This looks ready to merge. Thanks for your help.

@felicitymay felicitymay enabled auto-merge (squash) April 27, 2022 10:34
@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Apr 27, 2022
@felicitymay felicitymay merged commit cc5b24d into github:main Apr 27, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team engineering Will involve Docs Engineering get started Content related to "Getting Started" doc set ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants