Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub desktop fork instructions #34151

Closed

Conversation

Nikkitory
Copy link
Contributor

@Nikkitory Nikkitory commented Jul 31, 2024

Why: The current fork instructions for Github desktop were out of date with the latest Github desktop.

Closes: desktop/desktop#13165 (I realize this is an issue from a different repository, however in the comment thread of that issue you will see people mentioning that the issue arises because the docs here need updating.)

What's being changed (if available, include any code snippets, screenshots, or gifs): Minor documentation changes, inluding updating screenshots. The easiest way to see the changes would be to look at the PRs file changes.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Jul 31, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 31, 2024
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/assets/lib/image-density.txt

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
desktop/adding-and-cloning-repositories/cloning-and-forking-repositories-from-github-desktop.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
get-started/exploring-projects-on-github/contributing-to-a-project.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@Nikkitory Thank you so much for opening this PR! ✨ I have filed an internal issue to fix this on our end, as this portion of the documentation will need to be updated by our team 💛

Thanks again for raising a flag on this ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team desktop Content related to GitHub Desktop and removed triage Do not begin working on this issue until triaged by the team labels Jul 31, 2024
@nguyenalex836 nguyenalex836 reopened this Aug 5, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 5, 2024
@nguyenalex836
Copy link
Contributor

@Nikkitory Apologies for the confusion, but it looks like these changes may not need to be made internally 💛 I'm reopening this PR, and one of our team members will review shortly. Thank you!

@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Aug 5, 2024
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Aug 12, 2024
@github-actions github-actions bot closed this Aug 12, 2024
@nguyenalex836 nguyenalex836 reopened this Aug 12, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Aug 12, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Aug 12, 2024
Copy link
Member

@steveward steveward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request @Nikkitory! I've left comments for some changes I'd like to see made. Mainly, I'd like to keep the original screenshots and reusables and instead add new ones that represent the updates you were making to the originals. If you have any questions or need additional clarity, please let me know!

@@ -18,7 +18,7 @@ You can create a local copy of any repository on {% data variables.product.produ

When you clone a repository, any changes you push to {% data variables.product.product_name %} will affect the original repository. To make changes without affecting the original project, you can create a separate copy by forking the repository. You can create a pull request to propose that maintainers incorporate the changes in your fork into the original upstream repository. For more information, see "[AUTOTITLE](/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks)."

When you try to use {% data variables.product.prodname_desktop %} to clone a repository that you do not have write access to, {% data variables.product.prodname_desktop %} will prompt you to create a fork automatically. You can choose to use your fork to contribute to the original upstream repository or to work independently on your own project. Any existing forks default to contributing changes to their upstream repositories. You can modify this choice at any time. For more information, see "[Managing fork behavior](#managing-fork-behavior)".
When you use {% data variables.product.prodname_desktop %} to clone a repository that you do not have write access to, when you attempt to write to the repository, {% data variables.product.prodname_desktop %} will prompt you to create a fork. You can choose to use your fork to contribute to the original upstream repository or to work independently on your own project. Any existing forks default to contributing changes to their upstream repositories. You can modify this choice at any time. For more information, see "[Managing fork behavior](#managing-fork-behavior)".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you use {% data variables.product.prodname_desktop %} to clone a repository that you do not have write access to, when you attempt to write to the repository, {% data variables.product.prodname_desktop %} will prompt you to create a fork. You can choose to use your fork to contribute to the original upstream repository or to work independently on your own project. Any existing forks default to contributing changes to their upstream repositories. You can modify this choice at any time. For more information, see "[Managing fork behavior](#managing-fork-behavior)".
When you use {% data variables.product.prodname_desktop %} to push new commits to a repository that you do not have write access to, {% data variables.product.prodname_desktop %} will prompt you to create a fork. You can choose to use your fork to contribute to the original upstream repository or to work independently on your own project. Any existing forks default to contributing changes to their upstream repositories. You can modify this choice at any time. For more information, see "[Managing fork behavior](#managing-fork-behavior)".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the original screenshot and instead add this as a new screenshot showing how to clone via a URL. This allows us to have a github.com flow shown when this original screenshot is used in other articles, which is the common flow for cloning that we like to point users to.

Technically the fork prompt will work from any of the selections, since you can have read access to a repository, which will show up in the GitHub.com/GitHub Enterprise repo lists. Then an attempt to push new commits will prompt for fork creation. However, the most common path for cloning a fork is likely to enter a URL to clone, so it does make sense to use the URL tab for this flow.

@@ -1,8 +1,9 @@
In {% data variables.product.prodname_desktop %}, if you attempt to clone a repository that you don't have write access to, a fork is automatically created for you.
In {% data variables.product.prodname_desktop %}, if you clone a repository that you don't have write access to, and then attempt to write to the repository, a fork will be created for you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In {% data variables.product.prodname_desktop %}, if you clone a repository that you don't have write access to, and then attempt to write to the repository, a fork will be created for you.
In {% data variables.product.prodname_desktop %}, if you clone a repository that you don't have write access to, and then attempt to push new commits to the repository, a fork will be created for you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the original screenshot and add this as a new screenshot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this reusable and create a new one with the URL tab option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above -- let's keep this reusable as is and create a new one specific to cloning via a URL.

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Aug 16, 2024
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Aug 23, 2024
Copy link
Contributor

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

@github-actions github-actions bot closed this Aug 23, 2024
@warp-core
Copy link
Contributor

Would it be ok if I copied the head branch from here, made the requested changes, and created a new pull request?

@nguyenalex836
Copy link
Contributor

@warp-core Please do! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team desktop Content related to GitHub Desktop more-information-needed More information is needed to complete review stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub desktop cannot automatically prompt me to create a fork
4 participants