Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evaluate-expressions-in-workflows-and-actions.md #36232

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mark-mxwl
Copy link
Contributor

Why:

Closes: #32305

What's being changed (if available, include any code snippets, screenshots, or gifs):

As agreed upon in the linked issue, additional hashFiles examples were added, showcasing more advanced pattern matching options. In keeping with the tech referenced in the article's current examples (JavaScript/Ruby), the following file extensions were used: .js and .rb. The single-pattern examples provide use-cases for patterns involving fixed-level directory search and recursive subdirectory search. The multi-pattern example makes use of a fixed-level exclude ! pattern in a recursive subdirectory search.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 10, 2025
Copy link
Contributor

👓 Previews for changed content

This comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the review server. Please note that changes to the data directory will not show up in this table.

‼️ You can also preview changes using Codespaces or by spinning up a local environment. If you have trouble with the review server, use one of those options to preview your changes.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

@subatoi
Copy link
Contributor

subatoi commented Feb 10, 2025

Hi @mark-mxwl, many thanks for your submission—I'll get this triaged for a review from a member of the team

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 10, 2025
nafeef123

This comment was marked as spam.

Copy link
Contributor

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More complex examples like the ones here would definitely be a nice addition. Thanks for working on this.

@github github deleted a comment from nafeef123 Feb 11, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @mark-mxwl! This is all good to go, so I'll get this merged for you now. Thanks also to @hamirmahal for promptly confirming it's an appropriate closure for the original issue—it's always good to see the community in action ✨

@subatoi subatoi added this pull request to the merge queue Feb 11, 2025
Merged via the queue into github:main with commit 91ac1d2 Feb 11, 2025
72 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More sophisticated example for hashFiles function
5 participants