-
Notifications
You must be signed in to change notification settings - Fork 60.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update evaluate-expressions-in-workflows-and-actions.md #36232
Conversation
👓 Previews for changed contentThis comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server |
Hi @mark-mxwl, many thanks for your submission—I'll get this triaged for a review from a member of the team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More complex examples like the ones here would definitely be a nice addition. Thanks for working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @mark-mxwl! This is all good to go, so I'll get this merged for you now. Thanks also to @hamirmahal for promptly confirming it's an appropriate closure for the original issue—it's always good to see the community in action ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #32305
What's being changed (if available, include any code snippets, screenshots, or gifs):
As agreed upon in the linked issue, additional
hashFiles
examples were added, showcasing more advanced pattern matching options. In keeping with the tech referenced in the article's current examples (JavaScript/Ruby), the following file extensions were used:.js
and.rb
. The single-pattern examples provide use-cases for patterns involving fixed-level directory search and recursive subdirectory search. The multi-pattern example makes use of a fixed-level exclude!
pattern in a recursive subdirectory search.Check off the following: