Skip to content

Please update to Go 1.16 and also release for macOS ARM64 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbast opened this issue Feb 18, 2021 · 4 comments · Fixed by #73
Closed

Please update to Go 1.16 and also release for macOS ARM64 #68

dbast opened this issue Feb 18, 2021 · 4 comments · Fixed by #73

Comments

@dbast
Copy link
Contributor

dbast commented Feb 18, 2021

Go 1.16 was just released with macOS ARM64 support, see https://blog.golang.org/go1.16
@abhinav abhinav mentioned this issue Feb 19, 2021
Closed
5 tasks
@dbast
Copy link
Contributor Author

dbast commented Feb 20, 2021

Regarding signing and darwin_arm64 binaries ... go 1.16 automatically adds an add hoc signature, see the comment here git-lfs/git-lfs#4403

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this issue Feb 20, 2021
@abhinav @BrewTestBot
git-sizer: Set GO111MODULE=auto for Go 1.16
9ba8011 
This will let git-sizer build with Go 1.16.

master on git-sizer already has a go.mod but a release hasn't been
tagged yet.

Existing issue on git-sizer to update to 1.16: github/git-sizer#68.

Epic: #47627

Closes #71527.

Signed-off-by: Sean Molenaar <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
@mhagger
Copy link
Member

mhagger commented Feb 27, 2021

I'd like to wait for a 1.16.1 before switching over, to give some time for any problems in the 1.16 series to get ironed out. It should be pretty easy to build this yourself if you want to do any testing before then.

@dbast
Copy link
Contributor Author

dbast commented Mar 25, 2021

Go 1.16.2 is out https://golang.org/doc/devel/release.html#go1.16.minor :)

@mhagger mhagger mentioned this issue Apr 19, 2021
Merged
@mhagger
Copy link
Member

mhagger commented Apr 19, 2021

@dbast: This is implemented by #73. Would you be able to test that (the installation of the vendored Go toolchain, the build, and that the executable works)? I don't have that OS let alone that hardware version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for building on and for Darwin:arm64 github/git-sizer
2 participants
@mhagger @dbast