-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building on and for Darwin:arm64 #73
Conversation
Make sure to download the Go toolchain that matches the architecture of the host where the `Makefile` is being run.
It's no longer supported by the Go toolchain.
Nice. Thanks! Calling make with system pre-installed go 1.16.3 works and the binaries also work. Also cross compiled binaries work, compiled on linux amd64 and tested on Apple M1 hardware Calling make with no pre-installed go, downloads go, but then fails with:
After calling |
Hm... seems like some effort was put into the Makefile + shell scripts in |
Things are a lot easier nowadays!
This keeps `go test` from getting upset if there is a `vendor` directory with a vendored Go toolchain in it.
@dbast: Thanks for the help! I just pushed some more changes to this branch that will hopefully improve things. Please let me know if this does it for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and Makefile looks much cleaner now.
Thanks for working on this and merging the update. Care to tag a new minor release, which makes it easier for those who package git-sizer for various distributions? Thx! |
Update to Go 1.16.3, which includes support for Darwin:arm64. On the other hand, Darwin:386 is no longer supported, so remove that from the list of releases that we build.
Fixes #68
/cc @dbast, who requested this.