Run npx eslint . --ext .js,.ts --fix

[silverwind]

npm run build refused to proceed building without this.

I think the issue is because some eslint module is not properly locked down to a particular version. It would be even better to not have linting as a dependency to the build.

[silverwind]

Hmm, the CI now suggests the inverse. There must be something wrong with my setup I suppose. Will try a fresh clone.

[silverwind]

Nope, still present on fresh clone. Very strange. Node 21.7.1, npm 10.5.0.

$ npm i
added 583 packages in 34s
$ npm run build
> @github/relative-time-element@0.0.0-development prebuild
> npm run clean && npm run lint && mkdir dist


> @github/relative-time-element@0.0.0-development clean
> rm -rf dist


> @github/relative-time-element@0.0.0-development lint
> eslint . --ext .js,.ts && tsc --noEmit


/Users/silverwind/git/relative-time-element/src/duration-format-ponyfill.ts
  111:11  error  Insert `··`  prettier/prettier
  112:1   error  Insert `··`  prettier/prettier

/Users/silverwind/git/relative-time-element/src/duration.ts
  5:20  error  Replace `typeof·unitNames` with `(typeof·unitNames)`  prettier/prettier

/Users/silverwind/git/relative-time-element/src/relative-time-element.ts
   2:67  error  Replace `typeof·window` with `(typeof·window)`                                                                                                                                                                                           prettier/prettier
  14:15  error  Replace `public·oldText:·string,·public·newText:·string,·public·oldTitle:·string,·public·newTitle:·string` with `⏎····public·oldText:·string,⏎····public·newText:·string,⏎····public·oldTitle:·string,⏎····public·newTitle:·string,⏎··`  prettier/prettier

✖ 5 problems (5 errors, 0 warnings)
  5 errors and 0 warnings potentially fixable with the `--fix` option.

[keithamus]

What is your git rev-parse HEAD?

[silverwind]

1a42a317372e09b08fe430fe36f2598d2039bbfa, tip of main branch. Also tried another machine, same result. Maybe something about node 21, CI still uses node 18.

[keithamus]

I'm unable to repro. I wonder if you have one of these tools installed globally which is overriding the local version or something? Whats the output of npm ls -g prettier or npm ls -g eslint?

[silverwind]

Yes, I have many global packages. Will try to uninstall. Meanwhile I tested in a fresh docker container with node 21, and it does work in there, so this must be some npm global influence.

[silverwind]

Found the problem. My ~/.npmrc contains lockfile-version=3, but this package has lockfileVersion=2, which is a legacy format that contains two entries for each module, while version 3 only contains one, so likely npm installed different versions for some dependencies than are in the lockfile.

Checking whether I can remove this without causing npm to write new lockfiles in v2, which I want to avoid...

[silverwind]

Yeah, npm v10.5.0 still writes new v3 lockfiles, so the option was unnecessary and I removed it. Sorry for the trouble. The problem could have been avoided by declaring lockfileVersion in .npmrc in the project, but I'm not convinced this is really worth the effort.

[silverwind]

After testing #278, it turns out I made an error (I had moved away the ~/.npmrc and was not cleanly reinstalling node_modules). The actual cause in my ~/.npmrc was package-lock=false which made npm ignore the lockfile entirely. I'm suprised this option hadn't bitten me sooner.