Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing repo on archive plugin #751

Open
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from

Conversation

PendaGTP
Copy link
Contributor

@PendaGTP PendaGTP commented Jan 24, 2025

Description

This PR fixes several issues with the Archive plugin:

  • PR preview changes were not working when only archived status was updated
  • Archive plugin now properly archives repositories after syncing other settings
  • Archive plugin now unarchives repositories before syncing other settings
  • Fixed handling of missing repositories which previously caused errors (e.g: when new repositories needed to be created)
  • Added missing event handlers for repository.archive and repository.unarchive

Changes:

  • Resolved all issues listed above
  • Improved code formatting and linting for Archive plugin
  • Enhanced logging and error handling for Archive plugin
  • Updated related test cases

Tests Done

  • Manual testing of all scenarios related to Archive
  • Unit tests

@PendaGTP PendaGTP force-pushed the fix/handle-missing-repo-on-archive-plugin branch from 3931e9c to dd6ded1 Compare January 24, 2025 23:22
@PendaGTP
Copy link
Contributor Author

This PR also fixes an additional issue: repository synchronization failing when creating a new repository using .github/repos/new-repo.yml. While both app mode and full-sync mode currently fail (the latter due to archive plugin issues addressed in the open PR #751), this PR specifically addresses the app mode failure by implementing the fixes listed above.

@PendaGTP PendaGTP force-pushed the fix/handle-missing-repo-on-archive-plugin branch from dd6ded1 to 189feb7 Compare January 28, 2025 08:54
@PendaGTP
Copy link
Contributor Author

Hi @decyjphr any throughts on this? I have rebased with latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant