feat: add "Mark as done on open" setting #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adufr
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
setchy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues related
Implements #714
Context
This PR introduces a new setting which I called "Mark as done on open" (defaults to
false).It takes advantage of the new API to mark a notification as done, and replaces the old "Mark as read on click" setting (which was removed in #713 because it became obsolete).
The PR also includes test, I pretty much copy-pasted everything from #713 to implement both the feature and the test, so there's really nothing new 😉
Discussion
I decided to name the setting "Mark as done on open" instead of "Mark as done on click" because "click" felt too vague to me (click on what?)
This can be discussed.