Skip to content

Add import function with name parameter #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

schott89
Copy link
Contributor

@schott89 schott89 commented Mar 27, 2024

contributes to #1107

@schott89 schott89 closed this Mar 27, 2024
@schott89 schott89 reopened this Mar 27, 2024
@jmini
Copy link
Collaborator

jmini commented Mar 27, 2024

Thank you for this contribution.

Wouldn't it make sense to extract the name from the overrideParams parameter. The Project type has a getName() that could be used.

@schott89 schott89 force-pushed the Add-name-attribute-to-project-import-and-export-api branch from 02c073d to 0b371ab Compare March 27, 2024 16:05
@schott89
Copy link
Contributor Author

schott89 commented Mar 27, 2024

sounds good. done.

@jmini jmini merged commit ed0ebb6 into gitlab4j:main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants