Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute 'tier' to Environment model #1146

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

Rusev11
Copy link
Contributor

@Rusev11 Rusev11 commented Jul 26, 2024

  • Add attribute tier to Environment model
  • Update createEnvironment and updateEnvironment in EnvironmentApi

@Rusev11 Rusev11 changed the title Fetch environment's property 'tier' Add environment's property 'tier' Jul 30, 2024
@Rusev11 Rusev11 changed the title Add environment's property 'tier' Add attribute 'tier' to Environment model Jul 30, 2024
@Rusev11
Copy link
Contributor Author

Rusev11 commented Jul 30, 2024

@jmini Could you please review this Pull request?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the attribute in the src/test/resources/org/gitlab4j/api/environment.json used in the TestGitLabApiBeans test class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Rusev11
Copy link
Contributor Author

Rusev11 commented Aug 6, 2024

Should I bump the version?

@jmini jmini merged commit 9f969f8 into gitlab4j:main Aug 7, 2024
1 check passed
@jmini
Copy link
Collaborator

jmini commented Aug 7, 2024

I added a backward compatible method (with a @Deprecated annotation) on main and I removed it on 6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants