Restore API compatibility with 5.5.0 and earlier releases #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlab4j@224f4c5#commitcomment-145297850 notes that the change from boolean to Boolean is a breaking change in the API. It seems easiest and safest to restore API compatibility rather than requiring lock-step upgrades from consumers of the API. Jenkins (as an example) allows users to upgrade the GitLab API plugin without requiring that they upgrade the GitLab branch source plugin. When that happens, the breaking change in the API causes runtime failures for Jenkins users. jenkinsci/gitlab-branch-source-plugin#435 reports some of those runtime failures. https://issues.jenkins.io/browse/JENKINS-73672 reports more runtime failures due to the breaking change in the API. Fixes gitlab4j#1155
MarkEWaite
referenced
this pull request
Aug 27, 2024
…1123) --------- Co-authored-by: Jeremie Bresson <[email protected]>
6 tasks
|
@MarkEWaite Note that as of jenkinsci/gitlab-branch-source-plugin#438 we're actually depending on the new signature 😬 |
|
Closing this pull request so that it won't be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore API compatibility with 5.5.0 and earlier releases
224f4c5#commitcomment-145297850 notes that the change from boolean to Boolean is a breaking change in the API.
It seems easiest and safest to restore API compatibility rather than requiring lock-step upgrades from consumers of the API. Jenkins (as an example) allows users to upgrade the GitLab API plugin without requiring that they upgrade the GitLab branch source plugin. When that happens, the breaking change in the API causes runtime failures for Jenkins users.
jenkinsci/gitlab-branch-source-plugin#435 reports some of those runtime failures.
JENKINS-73672 reports more runtime failures due to the breaking change in the API.
Fixes #1155