Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job and applicationsettings #1169

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

gjkersten
Copy link
Contributor

Add failure reason to the Job object.

Updated the application settings (wanted to be able to set project_jobs_api_rate_limit)

@jmini jmini force-pushed the fix-job-applicationsettings branch from 3d42c2b to 576b9f2 Compare October 13, 2024 05:12
@jmini jmini changed the base branch from 6.x to main October 13, 2024 05:12
@jmini
Copy link
Collaborator

jmini commented Oct 13, 2024

I have rebased the source branch of this PR (fix-job-applicationsettings in the gjkersten fork) on top of main of this repo:

git rebase --onto origin/main gjkersten/fix-job-applicationsettings
git push gjkersten HEAD:fix-job-applicationsettings --force

Be aware that your local branch fix-job-applicationsettings has diverged with the one on the GitHub.

If you need to do one more changes on this branch:
I recommend to use git fetch and git reset --hard origin/fix-job-applicationsettings (assuming your local origin is pointing to the gjkersten fork on GitHub) before doing any local modifications instead of git pull.

I have changed the target branch of this PR to be main

@jmini jmini merged commit 11b6bb2 into gitlab4j:main Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants