-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] fix toast contrast #20630
Conversation
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
I'll take a look at what I can do |
@geropl when you say that we don't have contrast in light mode for the info banners, do you mean this? It looks fine with me, and Firefox says it WCAG AA compliant |
Yes! 🎯 Don't even see any diff in your screenshot, so I guess it's a monitor/OS colour scheme issue 😆 |
Tool: gitpod/catfood.gitpod.cloud
@geropl if you can take a look (maybe on your phone to display it properly :) at the PR description's screenshots, I updated them to reflect your suggestion. I quite like it and its nice to not invent a new color combination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Description
Fixes the contrast of our toasts
Related Issue(s)
Fixes #20577 (comment)
How to test
Visit https://ft-toast-contrast.preview.gitpod-dev.com/user/preferences and click on "Reset Options" or do anything else that triggers a toast.
/hold