Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix toast contrast #20630

Merged
merged 3 commits into from
Feb 25, 2025
Merged

[dashboard] fix toast contrast #20630

merged 3 commits into from
Feb 25, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 25, 2025

Description

Fixes the contrast of our toasts

Before After (light) After (dark)
image image image

Related Issue(s)

Fixes #20577 (comment)

How to test

Visit https://ft-toast-contrast.preview.gitpod-dev.com/user/preferences and click on "Reset Options" or do anything else that triggers a toast.

/hold

Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
@geropl
Copy link
Member

geropl commented Feb 25, 2025

I'm no designer by any means, but I struggle a bit with that contrast being a bit to high.

What about using this as background:
dark:
image

white:
Hm, seems we don't have contrast here, either 😬

@filiptronicek
Copy link
Member Author

I'll take a look at what I can do

@filiptronicek
Copy link
Member Author

@geropl when you say that we don't have contrast in light mode for the info banners, do you mean this? It looks fine with me, and Firefox says it WCAG AA compliant
image

@geropl
Copy link
Member

geropl commented Feb 25, 2025

when you say that we don't have contrast in light mode for the info banners, do you mean this?

Yes! 🎯 Don't even see any diff in your screenshot, so I guess it's a monitor/OS colour scheme issue 😆

Tool: gitpod/catfood.gitpod.cloud
@filiptronicek
Copy link
Member Author

@geropl if you can take a look (maybe on your phone to display it properly :) at the PR description's screenshots, I updated them to reflect your suggestion. I quite like it and its nice to not invent a new color combination

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@roboquat roboquat merged commit 0fd821f into main Feb 25, 2025
31 checks passed
@roboquat roboquat deleted the ft/toast-contrast branch February 25, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants