- tests/behat/behat_theme_adaptable_behat_auth.php duplicated the pat… #31
Conversation
…tern /^I log out$/ which Behat doesn't like. As it turns out, this isn't required as the core step definition works. - tests/behat/core_auth/behat_theme_adaptable_behat_core_auth.php is not how you extending existing Behat steps. https://moodledev.io/general/development/tools/behat/writing#override-behat-core-context-for-theme-suite describes how to do this. Regardless, ss it turns out, this isn't required as the core step definition works. - Changes to behat_theme_adaptable_behat_navigation.php and behat_theme_adaptable_behat_permissions.php are required because they define duplicate step definition patters which is not something Behat likes. If you take a look at Moodle's \behat_theme_boost_behat_navigation::i_should_see_is_active_in_navigation, they provide an example of how to deal with this. - blacklist.json excludes behat_theme_boost_behat_navigation from the list of contexts for the adaptable suite which gets built when you init Behat. For reference, /var/www/behatdata/behatrun/behat/behat.yml should be referred to to better understand why gets configured when Behat is initialized. - navigation.feature is a simple Behat test which logs in and out as admin both with javascript enabled and not.
|
@eric-s-richer I've reviewed the changes in the request and I agree with what you're proposing. Please submit a pull request on the 'main' branch in the development repository or state if you'd like me to make the same changes there. |
|
@eric-s-richer Question. Given that the code was originally created such that the core features could be tested against the theme, i.e. with the '--suite' running directive. Have you tried this? I'm told that the tests take many hours to run and even with MySQL using a memory based ramdisk, then I don't believe my machine could run the tests before I needed to sleep again. |
We run Behat tests every night on our CI server. I can confirm that it takes hours to complete. |
@gjb2048 I think I'm missing something. Where is the development repo? |
|
@eric-s-richer Details in the GitHub email sent to Luc.
… Message ID: ***@***.***
com>
|
|
I'll manage this pull request through the other account. |
…tern /^I log out$/ which Behat doesn't like. As it turns out, this isn't required as the core step definition works.
tests/behat/core_auth/behat_theme_adaptable_behat_core_auth.php is not how you extending existing Behat steps. https://moodledev.io/general/development/tools/behat/writing#override-behat-core-context-for-theme-suite describes how to do this. Regardless, ss it turns out, this isn't required as the core step definition works.
Changes to behat_theme_adaptable_behat_navigation.php and behat_theme_adaptable_behat_permissions.php are required because they define duplicate step definition patters which is not something Behat likes. If you take a look at Moodle's \behat_theme_boost_behat_navigation::i_should_see_is_active_in_navigation, they provide an example of how to deal with this.
blacklist.json excludes behat_theme_boost_behat_navigation from the list of contexts for the adaptable suite which gets built when you init Behat. For reference, /var/www/behatdata/behatrun/behat/behat.yml should be referred to to better understand why gets configured when Behat is initialized.
navigation.feature is a simple Behat test which logs in and out as admin both with javascript enabled and not.