feat: license management feature flag #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christophenne <[email protected]>
Signed-off-by: christophenne <[email protected]>
Signed-off-by: christophenne <[email protected]>
Signed-off-by: christophenne <[email protected]>
Signed-off-by: christophenne <[email protected]>
pmig
previously requested changes
Feb 10, 2025
|
I think I found the problem, and it appears to be a bug in pgx!! I think if you replace LoadTypes(...) and RegisterTypes(...) in the svc package with a loop around LoadType(...) and RegisterType(...) it should work! |
|
Debugging the createDBPool function … it appears that the pgTypes returned by conn.LoadTypes is just an empty slice lol |
|
I created the following related issue in the pgx repo: jackc/pgx#2254 For now it's probably easiest to just load each type individually. |
…ype handling Signed-off-by: christophenne <[email protected]>
Signed-off-by: christophenne <[email protected]>
kosmoz
reviewed
Feb 11, 2025
Signed-off-by: christophenne <[email protected]>
christophenne
deleted the
christophenne/gk-518-organization-feature-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I couldn't make an enum array work with pgx, so I opted for the boolean for now. We can still revisit/refactor/migrate on the second, or latest, third occurrence of a feature flag.
As a positive side effect, I think the manual updating of a db entry will be more straight forward for now 🤷♂️