Clippy lints #32
Draft
Clippy lints #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pi-Cla
force-pushed
the
ownerlevel-valueenum
branch
from
63653bb to
ce3ac19
Compare
Pi-Cla
changed the title
clap::ValueEnum derivation to OwnerLevel 
|
@lpil Should I add clap as a dependency and derive Alternatively I could instead just make the clap command take a string and then manually pattern match against the string. This I think(?) would require a new Error variant to be added to gleam-core which mimics what Clap already says with invalid arguments though. |
|
I'm not sure what you mean, sorry. We don't want to depend on Clap at all here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just clippy lints