Skip to content

Change how tracing is disabled #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 0.4.x
Choose a base branch
from
Open

Change how tracing is disabled #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions src/main/java/com/glencoesoftware/omero/ms/image/region/ImageRegionMicroserviceVerticle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.regex.Pattern;

import org.slf4j.LoggerFactory;
import org.springframework.context.ApplicationContext;
Expand Down Expand Up @@ -175,26 +176,39 @@ public void deploy(JsonObject config, Promise<Void> prom) {
httpTracingConfig.getBoolean("enabled", false);
if (tracingEnabled) {
String zipkinUrl = httpTracingConfig.getString("zipkin-url");
log.info("Tracing enabled: {}", zipkinUrl);
sender = OkHttpSender.create(zipkinUrl);
spanReporter = AsyncReporter.create(sender);
PrometheusSpanHandler prometheusSpanHandler = new PrometheusSpanHandler();
tracing = Tracing.newBuilder()
.sampler(Sampler.ALWAYS_SAMPLE)
.localServiceName("omero-ms-image-region")
.addFinishedSpanHandler(prometheusSpanHandler)
.spanReporter(spanReporter)
.build();
try {
log.info("Tracing enabled: {}", zipkinUrl);
if(Pattern.matches("^http.*", zipkinUrl)) {
log.info("Tracing enabled: {}", zipkinUrl);
sender = OkHttpSender.create(zipkinUrl);
spanReporter = AsyncReporter.create(sender);
PrometheusSpanHandler prometheusSpanHandler = new PrometheusSpanHandler();
tracing = Tracing.newBuilder()
.sampler(Sampler.ALWAYS_SAMPLE)
.localServiceName("omero-ms-image-region")
.addFinishedSpanHandler(prometheusSpanHandler)
.spanReporter(spanReporter)
.build();
} else if (Pattern.matches("^slf4j.*", zipkinUrl)) {
PrometheusSpanHandler prometheusSpanHandler = new PrometheusSpanHandler();
spanReporter = new LogSpanReporter();
tracing = Tracing.newBuilder()
.sampler(Sampler.ALWAYS_SAMPLE)
.localServiceName("omero-ms-image-region")
.addFinishedSpanHandler(prometheusSpanHandler)
.spanReporter(spanReporter)
.build();
} else {
throw new IllegalArgumentException("Invalid URL configured for tracing");
}
} catch (Exception e) {
log.error("Tracing enabled but configured incorrectly");
throw e;
}
} else {
log.info("Tracing disabled");
PrometheusSpanHandler prometheusSpanHandler = new PrometheusSpanHandler();
spanReporter = new LogSpanReporter();
tracing = Tracing.newBuilder()
.sampler(Sampler.ALWAYS_SAMPLE)
.localServiceName("omero-ms-image-region")
.addFinishedSpanHandler(prometheusSpanHandler)
.spanReporter(spanReporter)
.build();
tracing = Tracing.newBuilder().build();
tracing.setNoop(true);
}
httpTracing = HttpTracing.newBuilder(tracing).build();

Expand Down