Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime setuptools dependency #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kajaste
Copy link
Contributor

@kajaste kajaste commented Nov 17, 2023

Prefer importlib.metadata core library which is available on Python >= 3.8

This gets rid of setuptools dependency for stopit users. Recent setuptools versions output a massive deprecation warning about pkg_resources usage whenever stopit is imported:

DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html)

Additionally, not all Python environments have setuptools these days, which makes import stopit fail.

Also: update supported Python versions in setup.py with versions I have successfully used stopit on

PS. Thank you so much for the awesome library. It has helped me through several hardships over the years

Prefer importlib.metadata core library on Python >= 3.8

This gets rid of setuptools dependency from stopit users. Recent
setuptools versions output a massive deprecation warning about
pkg_resources usage:
DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

Also: update supported Python versions in setup.py with versions I have
used stopit successfully on
@peterjc
Copy link

peterjc commented Aug 7, 2024

I also was troubled by this deprecation warning (triggered via snakemake), and identified the same pkg_resources.get_distribution(__name__).version change to fix it. Applying this fix and doing a point release would be appreciated.

(As an aside, if you are looking for a volunteer to help with or take over maintenance of the package, reaching out to the snakemake community seems sensible.)

@akozlu
Copy link

akozlu commented Nov 1, 2024

shippppppppp it 🚢 🚢

@kajaste
Copy link
Contributor Author

kajaste commented Dec 16, 2024

shippppppppp it 🚢 🚢

Shipped it at https://github.com/kajaste/overdue (implemented the same idea in modern Python and tooling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants