Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-41] - Fix Batch Control Override and Update Company Identification to Alphanumeric #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Issue-41] - Fix Batch Control Override and Update Company Identification to Alphanumeric #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f598e9
Update Batch companyId to be alphanumeric
Oct 22, 2024
c4c4216
Fix Batch control override
Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/batch/control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module.exports = {
width: 10,
position: 7,
required: true,
type: 'numeric'
type: 'alphanumeric'
},

messageAuthenticationCode: {
Expand Down
2 changes: 1 addition & 1 deletion lib/batch/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ module.exports = {
width: 10,
position: 5,
required: true,
type: 'numeric',
type: 'alphanumeric',
value: ''
},

Expand Down
2 changes: 1 addition & 1 deletion lib/batch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function Batch(options) {

// Allow the batch header/control defaults to be overriden if provided
this.header = options.header ? _.merge(options.header, require('./header'), _.defaults) : _.cloneDeep(require('./header'));
this.control = options.control ? _.merge(options.header, require('./control'), _.defaults) : _.cloneDeep(require('./control'));
this.control = options.control ? _.merge(options.control, require('./control'), _.defaults) : _.cloneDeep(require('./control'));

// Configure high-level overrides (these override the low-level settings if provided)
utils.overrideLowLevel(highLevelHeaderOverrides, options, this);
Expand Down