Lint and config changes extraction part two (#1502)

* Krausest benchmark needs a lint config to properly configure sourceType

* Try to figure out why vm-babel-plugins doesn't appear to be linting correctly

* Get the build working

* Additional ignores

* Fix lints for vm-babel-plugins

* reduceLock

* lint:fix

benchmark/benchmarks/krausest/.eslintrc.cjs

@@ -0,0 +1,13 @@
+/** @type {import("eslint").Linter.Config} */
+module.exports = {
+  root: false,
+  overrides: [
+    {
+      files: ['**/*.js'],
+      parserOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+    },
+  ],
+};

packages/@glimmer-workspace/build/lib/config.js

@@ -90,11 +90,18 @@ export function typescript(pkg, config) {
 
   const ts = tsconfig(typeScriptConfig);
 
+  /**
+   * TODO: migrate off of rollupTS, it has too many bugs
+   */
   return rollupTS({
     transpiler: 'babel',
     transpileOnly: true,
     babelConfig: { presets },
-
+    /**
+     * This shouldn't be required, but it is.
+     * If we use @rollup/plugin-babel, we can remove this.
+     */
+    browserslist: [`last 1 chrome versions`],
     tsconfig: ts,
   });
 }

packages/@glimmer/.eslintrc.cjs

@@ -79,6 +79,10 @@ module.exports = {
         'runtime/lib/modifiers/on.ts',
         'syntax/lib/parser/tokenizer-event-handlers.ts',
         'syntax/lib/get-template-locals.ts',
+        'syntax/lib/generation/printer.ts',
+        'syntax/lib/v2/normalize.ts',
+        'syntax/test/traversal/manipulating-node-test.ts',
+        'node/lib/node-dom-helper.ts',
       ],
       rules: {
         'deprecation/deprecation': 'warn',

packages/@glimmer/vm-babel-plugins/package.json

@@ -26,11 +26,11 @@
   "devDependencies": {
     "@glimmer-workspace/build-support": "workspace:^",
     "babel-plugin-tester": "^11.0.4",
-    "eslint": "^8.52.0",
     "mocha": "^10.2.0",
     "publint": "^0.2.5",
     "rollup": "^3.21.6",
-    "typescript": "*"
+    "typescript": "*",
+    "eslint": "^8.54.0"
   },
   "main": "index.ts",
   "types": "index.ts",

packages/@glimmer/vm-babel-plugins/test/.eslintignore

@@ -0,0 +1 @@
+fixtures/

packages/@glimmer/vm-babel-plugins/test/.eslintrc.cjs

@@ -9,4 +9,8 @@ module.exports = {
     require: true,
     __dirname: true,
   },
+  rules: {
+    '@typescript-eslint/no-require-imports': 'off',
+    '@typescript-eslint/no-var-requires': 'off',
+  },
 };

packages/@glimmer/vm-babel-plugins/test/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
-/* eslint-disable @typescript-eslint/no-require-imports */
 const path = require('node:path');
 const pluginTester = require('babel-plugin-tester');