Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering non-object, yet stringable values (Symbol?), moves Reflect.getPrototypeOf to Object.getPrototypeOf #1710

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 11, 2025

Copy link
Contributor

github-actions bot commented Feb 11, 2025

This PRmain
Dev
582K └─┬ .
169K   ├── runtime
159K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
582K └─┬ .
169K   ├── runtime
159K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
Prod
230K └─┬ .
 69K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner
230K └─┬ .
 69K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

@NullVoxPopuli NullVoxPopuli changed the title Failing test from https://github.com/emberjs/ember.js/pull/20842 Fix rendering non-object, yet stringable values (Symbol?), moves Reflect.getPrototypeOf to Object.getPrototypeOf Feb 11, 2025
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 11, 2025 22:11
@NullVoxPopuli NullVoxPopuli force-pushed the reproduce-problem-from-ember branch from bd3f613 to 057611b Compare February 11, 2025 22:50
@NullVoxPopuli
Copy link
Contributor Author

A note: the render1000 phases flip flop between which is a regression and are a bit sensitive to machine noise.

It's possible the run-count needs to be upped.

duration phase no difference [-26ms to 86ms]
renderEnd phase no difference [-1ms to 0ms]
render1000Items1End phase estimated regression +15ms [1ms to 20ms] OR +5.98% [0.21% to 8.14%]
clearItems1End phase no difference [-14ms to 0ms]
render1000Items2End phase no difference [-4ms to 13ms]
clearItems2End phase no difference [0ms to 3ms]
render5000Items1End phase no difference [-17ms to 50ms]
clearManyItems1End phase no difference [0ms to 2ms]
render5000Items2End phase no difference [-17ms to 17ms]
clearManyItems2End phase no difference [0ms to 0ms]
render1000Items3End phase no difference [-6ms to 98ms]
append1000Items1End phase no difference [-47ms to 5ms]
append1000Items2End phase no difference [-11ms to 9ms]
updateEvery10thItem1End phase no difference [0ms to 0ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [-16ms to 0ms]
selectSecondRow1End phase no difference [-3ms to 28ms]
removeFirstRow1End phase no difference [-2ms to 10ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-2ms to 1ms]
paint phase no difference [0ms to 0ms]

@NullVoxPopuli NullVoxPopuli merged commit c918fc9 into main Feb 11, 2025
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the reproduce-problem-from-ember branch February 11, 2025 23:29
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant