#62 Client now restarts after sync failures #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzyinq
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
I'm missing some information in logs along log.Fatal that this will cause process termination.
Btw how is it that command fails yet pod is not being restarted but process seems to handle it internally?
EDIT:
OK that's because of dev-entrypoint - so in real life scenario this will restart the pod right?
|
As to those parameters. I think I'll create an issue to dehardcode those random parameters. I try to put them in the constructions si i have them already plucked out to some extent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.