Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified activity_detail_server.xml and activity_list_servers.xml #414

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

good-good-create
Copy link
Contributor

Hello,

I just discovered an issue with the color. The text color on the button is also yellow, which results in insufficient color contrast and fails to meet accessibility standards, making it very hard to read. Therefore, it should be changed to black.

before:
before-1

after:
after-1

before:
before-2

after:
after-2

@stonebuzz stonebuzz self-requested a review February 26, 2025 07:54
@stonebuzz stonebuzz added the UI label Feb 26, 2025
@stonebuzz stonebuzz added this to the 1.6.2 milestone Feb 26, 2025
@stonebuzz
Copy link
Collaborator

Hi @good-good-create

Thank you for your contribution

Can you rebase your branch (to trigger the CIs)
Then add an entry in the CHANGELOG

Best regards

@good-good-create good-good-create changed the title Modified the xml files Modified activity_detail_server.xml and activity_list_servers.xml Feb 27, 2025
CHANGELOG.md Outdated
@@ -9,6 +9,8 @@ All notable changes to this project will be documented in this file.
- *(EMM)* Fix missing managed configurations used as NULL
- *(Core)* Exclude sensitive strings

### 💼 Other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put this entry in the bugfixes section

@stonebuzz stonebuzz self-requested a review February 27, 2025 15:37
@stonebuzz stonebuzz merged commit b6f42f2 into glpi-project:main Feb 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants