Initial work on supporting units in the scatter viewer#2509
Draft
astrofrog wants to merge 3 commits into
Draft
Conversation
astrofrog
force-pushed
the
scatter-units
branch
from
89e6aab to
4d0f673
Compare
astrofrog
force-pushed
the
scatter-units
branch
from
4d0f673 to
1573e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a work in progress - trying to figure out conceptually with whether the unit conversion stuff added here should result in any visual changes in the axes or just to the labels - as a specific example, if one has two datasets in compatible but different units, is it the responsibility of the user to link these with
LinkWithSameUnitsin order for them to be shown on the same scale, or is settingy_display_unitsenough? The latter is difficult to do in practice so maybe for now we should focus on the first.