Match MS Teams timestamp format #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it is Teams that is out of spec. I'm closing this as it's really a Team's problem. |
|
This should be resolved in #45. I disagree that we shouldn't fix it just because it's a Teams problem. If we're being pragmatic, Microsoft will never fix this and being compatible on our end costs us nothing in terms of accuracy or performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Microsoft Teams produces a timestamp format that appears to meet the WebVtt standard but the currently existing regular expression does not match against it.
The Team's timestamp format: 0:0:13.540 --> 0:0:17.850
This PR attempts to expand the regular expression to match this case.