Draw a tooltip if the user mouses over the spice icon#1042
Open
babbaj wants to merge 2 commits intognif:masterfrom
Open
Draw a tooltip if the user mouses over the spice icon#1042babbaj wants to merge 2 commits intognif:masterfrom
babbaj wants to merge 2 commits intognif:masterfrom
Conversation
jonpas
reviewed
Nov 9, 2022
Owner
|
I am sorry but this breaks interaction with anything that might be under the icon. It also is hard coding a lot of things that ideally should be loaded dynamically. And finally, changes like this are not being accepted at this time until we are back to our regular release cycle. |
Contributor
Author
|
This shouldn't break interaction any more than the icon already does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.