Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnodev): fix the use of filepath instead of path on windows #3737

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Feb 12, 2025

fix #3722

Using filepath to work with the path creates some obvious issues on Windows, primarily because the Clean function replaces / with \\. This PR updates the usage of filepath to path where necessary.

At some point, adapting path-specific tests on Windows would be very helpful.


@Milosevic02, can you confirm that this fix resolves most of your issues with gnodev?

EDIT: It seems that the fix is effective: #3722 (comment)

@gfanton gfanton self-assigned this Feb 12, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 12, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
contribs/gnodev/pkg/packages/loader_glob.go 75.00% 1 Missing and 1 partial ⚠️
contribs/gnodev/pkg/packages/resolver_local.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 12, 2025
@gfanton gfanton marked this pull request as ready for review February 12, 2025 15:15
@thehowl thehowl merged commit 70b8a70 into gnolang:master Feb 13, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

Source Page Not Displaying on GnoDev in Windows
3 participants