Skip to content

Conversation

@jachoo
Copy link

@jachoo jachoo commented Oct 20, 2023

This simple plugin adds a new keyboard shortcut [Ctrl+Shift+L] which clears all visible terminals by sending [Ctrl+L] to each terminal.

@mattrose
Copy link
Member

Confined to plugin code:

Good Things: Isolated
Bad things: Unable to check to see whether Ctrl-Shift-L is already taken by another keybind. Do you know what happens in this case?

@mattrose mattrose added the question Further information is requested label Feb 17, 2024
@jachoo
Copy link
Author

jachoo commented Feb 23, 2024

If a key is already bound, it will be overridden, which could potentially lead to issues when unbinding. This is a general problem of binding keys in current implementation of plugin.KeyBindUtil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants